sdk/lib/_internal/compiler/implementation/lib/js_array.dart - Issue 11348207: Fix runtimeType for List and bool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/js_array.dart

Issue 11348207: Fix runtimeType for List and bool. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Add a test. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/compiler/implementation/lib/js_array.dart

diff --git a/sdk/lib/_internal/compiler/implementation/lib/js_array.dart b/sdk/lib/_internal/compiler/implementation/lib/js_array.dart

index 684b7b81bd92011419cc6b4e1c5bec9f3e08bf41..a4f069d5170c50aab32eac8b2a25e43aaca00470 100644

--- a/sdk/lib/_internal/compiler/implementation/lib/js_array.dart

+++ b/sdk/lib/_internal/compiler/implementation/lib/js_array.dart

@@ -167,7 +167,10 @@ class JSArray<E> implements List<E> {

int get hashCode => Primitives.objectHashCode(this);

- Type get runtimeType => List;

+ Type get runtimeType {

+ // Call getRuntimeTypeString to get the name including type arguments.

+ return new TypeImpl(getRuntimeTypeString(this));

+ }

int get length => JS('int', r'#.length', this);