Issue 11348035: Move StringImplementation from coreimpl to core as _StringImpl.

Issue 11348035: Move StringImplementation from coreimpl to core as _StringImpl. (Closed)

Created:
8 years, 1 month ago by Anders Johnsen

Modified:
8 years, 1 month ago

Reviewers:
ahe, floitsch, Mads Ager (google)

CC:
reviews_dartlang.org, Lasse Reichstein Nielsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Move StringImplementation from coreimpl to core as _StringImpl. BUG=

Patch Set 1 #

Total comments: 4

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+108 lines, -109 lines)			Patch
M	lib/compiler/implementation/lib/core_patch.dart	View	1 chunk	+47 lines, -0 lines	4 comments	Download
M	lib/compiler/implementation/lib/coreimpl_patch.dart	View	1 chunk	+0 lines, -49 lines	0 comments	Download
M	lib/compiler/implementation/lib/string_helper.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	lib/core/string.dart	View	2 chunks	+20 lines, -1 line	0 comments	Download
M	lib/core/string_buffer.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/core/strings.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/coreimpl/coreimpl.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/coreimpl/corelib_impl_sources.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	lib/coreimpl/string.dart	View	1 chunk	+0 lines, -26 lines	0 comments	Download
M	runtime/lib/lib_impl_sources.gypi	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	runtime/lib/lib_sources.gypi	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/lib/regexp_patch.dart	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	runtime/lib/string_base.dart	View	2 chunks	+18 lines, -10 lines	0 comments	Download
M	runtime/lib/string_patch.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	runtime/vm/parser.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

Ahe, can you check the dart2js lib changes for me? Ty!

8 years, 1 month ago (2012-10-30 13:39:32 UTC) #1

floitsch

LGTM. https://codereview.chromium.org/11348035/diff/1/lib/compiler/implementation/lib/core_patch.dart File lib/compiler/implementation/lib/core_patch.dart (right): https://codereview.chromium.org/11348035/diff/1/lib/compiler/implementation/lib/core_patch.dart#newcode178 lib/compiler/implementation/lib/core_patch.dart:178: patch String join(List<String> strings, String separator) { should ...

8 years, 1 month ago (2012-10-30 13:53:05 UTC) #2

Anders Johnsen

8 years, 1 month ago (2012-10-30 14:19:31 UTC) #3

Thanks, landing.

https://codereview.chromium.org/11348035/diff/1/lib/compiler/implementation/l...
File lib/compiler/implementation/lib/core_patch.dart (right):

https://codereview.chromium.org/11348035/diff/1/lib/compiler/implementation/l...
lib/compiler/implementation/lib/core_patch.dart:178: patch String
join(List<String> strings, String separator) {
On 2012/10/30 13:53:05, floitsch wrote:
> should be static.

Done.

https://codereview.chromium.org/11348035/diff/1/lib/compiler/implementation/l...
lib/compiler/implementation/lib/core_patch.dart:185: patch String
concatAll(List<String> strings) {
On 2012/10/30 13:53:05, floitsch wrote:
> should be static.

Done.

Expand Messages | Collapse Messages