Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2429)

Unified Diff: runtime/lib/regexp_patch.dart

Issue 11348035: Move StringImplementation from coreimpl to core as _StringImpl. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/lib/regexp_patch.dart
diff --git a/runtime/lib/regexp_patch.dart b/runtime/lib/regexp_patch.dart
index 936a7fee4f9b8f098a762b2089278b659b3ba820..f9e5d6a7ee91a25816af01359a473ec3292d6115 100644
--- a/runtime/lib/regexp_patch.dart
+++ b/runtime/lib/regexp_patch.dart
@@ -26,7 +26,8 @@ class _JSRegExpMatch implements Match {
assert(endIndex == -1);
return null;
}
- return str._substringUnchecked(startIndex, endIndex);
+ // TODO(ajohnsen): Use _substringUnchecked when regexp is in core.
+ return str.substring(startIndex, endIndex);
}
String operator [](int groupIdx) {
@@ -98,7 +99,8 @@ patch class JSSyntaxRegExp {
if (match === null) {
return null;
}
- return str._substringUnchecked(match[0], match[1]);
+ // TODO(ajohnsen): Use _substringUnchecked when regexp is in core.
+ return str.substring(match[0], match[1]);
}
/* patch */ String get pattern native "JSSyntaxRegExp_getPattern";

Powered by Google App Engine
This is Rietveld 408576698