Issue 11348006: Remove file name from File C++ structure. It is not used.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11348006: Remove file name from File C++ structure. It is not used. (Closed)

Created:
8 years, 1 month ago by Mads Ager (google)

Modified:
8 years, 1 month ago

Reviewers:
Søren Gjesse, aam-me

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Remove file name from File C++ structure. It is not used. Currently, the field is being assigned a string that we immediately deallocate leaving the field invalid. Since it is not used we should get rid of it. R=aprelev@gmail.com,sgjesse@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=14188

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -12 lines)			Patch
M	runtime/bin/file.h	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	runtime/bin/file_android.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/bin/file_linux.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/bin/file_macos.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/bin/file_test.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/bin/file_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

lgtm