Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1187)

Unified Diff: runtime/bin/file.h

Issue 11348006: Remove file name from File C++ structure. It is not used. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/file_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/file.h
diff --git a/runtime/bin/file.h b/runtime/bin/file.h
index 7b6ea8c09653b584d514c9a6f90fcf36de2a84fb..50ad3b4efc1fd363b2d924a55bbdde656000aea6 100644
--- a/runtime/bin/file.h
+++ b/runtime/bin/file.h
@@ -109,8 +109,6 @@ class File {
// Returns whether the file has been closed.
bool IsClosed();
- const char* name() const { return name_; }
-
// Open the file with the given name. The file is always opened for
// reading. If mode contains kWrite the file is opened for both
// reading and writing. If mode contains kWrite and the file does
@@ -139,12 +137,11 @@ class File {
static Dart_Port GetServicePort();
private:
- File(const char* name, FileHandle* handle) : name_(name), handle_(handle) { }
+ explicit File(FileHandle* handle) : handle_(handle) { }
void Close();
static const int kClosedFd = -1;
- const char* name_;
// FileHandle is an OS specific class which stores data about the file.
FileHandle* handle_; // OS specific handle for the file.
« no previous file with comments | « no previous file | runtime/bin/file_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698