Fix for dartbug.com/6036: the intersection of two different types is not always conflicting.

Fix for dartbug.com/6036: the intersection of two different types is not always conflicting.
Committed: https://code.google.com/p/dart/source/detail?r=14278

[kasperl, 2012-10-30 12:33:46]

https://codereview.chromium.org/11341041/diff/2001/tests/compiler/dart2js/typ...
File tests/compiler/dart2js/type_combination_test.dart (right):

https://codereview.chromium.org/11341041/diff/2001/tests/compiler/dart2js/typ...
tests/compiler/dart2js/type_combination_test.dart:2031: Compiler compiler = new
MockCompiler();
Is it too nasty to use lazy static initialization for these? Maybe.

[karlklose, 2012-10-30 12:43:24]

https://codereview.chromium.org/11341041/diff/2001/tests/compiler/dart2js/typ...
File tests/compiler/dart2js/type_combination_test.dart (right):

https://codereview.chromium.org/11341041/diff/2001/tests/compiler/dart2js/typ...
tests/compiler/dart2js/type_combination_test.dart:38:
CONFLICTING.union(CONFLICTING, compiler));
You could use a helper union(a, b) => a.union(b, compiler). This would make the
rest of the test more readable.

[ngeoffray, 2012-10-30 12:58:41]

https://codereview.chromium.org/11341041/diff/2001/tests/compiler/dart2js/typ...
File tests/compiler/dart2js/type_combination_test.dart (right):

https://codereview.chromium.org/11341041/diff/2001/tests/compiler/dart2js/typ...
tests/compiler/dart2js/type_combination_test.dart:38:
CONFLICTING.union(CONFLICTING, compiler));
On 2012/10/30 12:43:24, karlklose wrote:
> You could use a helper union(a, b) => a.union(b, compiler). This would make
the
> rest of the test more readable.

There were some lines that were over 80 columns already, so that helper method
won't fix it for these lines. I actually prefer the consistency of how it is
right now (each Expect call has a new line).

[kasperl, 2012-10-30 13:00:43]

LGTM.

https://codereview.chromium.org/11341041/diff/2001/lib/compiler/implementatio...
File lib/compiler/implementation/ssa/types.dart (right):

https://codereview.chromium.org/11341041/diff/2001/lib/compiler/implementatio...
lib/compiler/implementation/ssa/types.dart:704: if (other is HBoundedType) {
It feels like this method could use some more comments. I have to think a bit
too much to understand what the different cases mean.

https://codereview.chromium.org/11341041/diff/2001/lib/compiler/implementatio...
lib/compiler/implementation/ssa/types.dart:732: && identical(isExact(), other
.isExact()));
Remove space before .

[ngeoffray, 2012-10-30 13:25:35]

Thanks Kasper

https://codereview.chromium.org/11341041/diff/2001/lib/compiler/implementatio...
File lib/compiler/implementation/ssa/types.dart (right):

https://codereview.chromium.org/11341041/diff/2001/lib/compiler/implementatio...
lib/compiler/implementation/ssa/types.dart:704: if (other is HBoundedType) {
On 2012/10/30 13:00:43, kasperl wrote:
> It feels like this method could use some more comments. I have to think a bit
> too much to understand what the different cases mean.

Done.

https://codereview.chromium.org/11341041/diff/2001/lib/compiler/implementatio...
lib/compiler/implementation/ssa/types.dart:704: if (other is HBoundedType) {
On 2012/10/30 13:00:43, kasperl wrote:
> It feels like this method could use some more comments. I have to think a bit
> too much to understand what the different cases mean.

Done.

https://codereview.chromium.org/11341041/diff/2001/lib/compiler/implementatio...
lib/compiler/implementation/ssa/types.dart:732: && identical(isExact(), other
.isExact()));
On 2012/10/30 13:00:43, kasperl wrote:
> Remove space before .

Done.

https://codereview.chromium.org/11341041/diff/2001/tests/compiler/dart2js/typ...
File tests/compiler/dart2js/type_combination_test.dart (right):

https://codereview.chromium.org/11341041/diff/2001/tests/compiler/dart2js/typ...
tests/compiler/dart2js/type_combination_test.dart:2031: Compiler compiler = new
MockCompiler();
On 2012/10/30 12:33:46, kasperl wrote:
> Is it too nasty to use lazy static initialization for these? Maybe.

Good we agree :)