Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Unified Diff: lib/compiler/implementation/ssa/codegen.dart

Issue 11341041: Fix for dartbug.com/6036: the intersection of two different types is not always conflicting. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/ssa/bailout.dart ('k') | lib/compiler/implementation/ssa/nodes.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/codegen.dart
===================================================================
--- lib/compiler/implementation/ssa/codegen.dart (revision 14260)
+++ lib/compiler/implementation/ssa/codegen.dart (working copy)
@@ -1661,7 +1661,9 @@
// involving only things with guaranteed number types and a given
// field.
bool isSimpleFieldNumberComputation(HInstruction value, HFieldSet node) {
- if (value.guaranteedType.union(HType.NUMBER) == HType.NUMBER) return true;
+ if (value.guaranteedType.union(HType.NUMBER, compiler) == HType.NUMBER) {
+ return true;
+ }
if (value is HBinaryArithmetic) {
return (isSimpleFieldNumberComputation(value.left, node) &&
isSimpleFieldNumberComputation(value.right, node));
« no previous file with comments | « lib/compiler/implementation/ssa/bailout.dart ('k') | lib/compiler/implementation/ssa/nodes.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698