Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 11337021: Change surroundingDeclaration to DeclarationMirror.owner (Closed)

Created:
8 years, 1 month ago by Johnni Winther
Modified:
8 years, 1 month ago
Reviewers:
ahe, kasperl
CC:
reviews_dartlang.org, Andrei Mouravski, turnidge
Visibility:
Public.

Description

Change surroundingDeclaration to DeclarationMirror.owner Committed: https://code.google.com/p/dart/source/detail?r=14264

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -32 lines) Patch
M pkg/dartdoc/lib/dartdoc.dart View 8 chunks +13 lines, -13 lines 0 comments Download
M pkg/dartdoc/lib/mirrors.dart View 2 chunks +8 lines, -6 lines 0 comments Download
M pkg/dartdoc/lib/mirrors_util.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart View 7 chunks +13 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/mirrors_test.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M utils/apidoc/apidoc.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/apidoc/html_diff.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Johnni Winther
8 years, 1 month ago (2012-10-30 11:08:11 UTC) #1
ahe
LGTM!
8 years, 1 month ago (2012-10-30 11:13:04 UTC) #2
kasperl
8 years, 1 month ago (2012-10-30 11:22:00 UTC) #3
LGTM too.

Powered by Google App Engine
This is Rietveld 408576698