Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: pkg/dartdoc/lib/dartdoc.dart

Issue 11337021: Change surroundingDeclaration to DeclarationMirror.owner (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/dartdoc/lib/mirrors.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dartdoc/lib/dartdoc.dart
diff --git a/pkg/dartdoc/lib/dartdoc.dart b/pkg/dartdoc/lib/dartdoc.dart
index 0128d618555602b88a8e1354da212a65b53152e3..2c8897ca048b3155e0ce1f22155fb1b1b25f553c 100644
--- a/pkg/dartdoc/lib/dartdoc.dart
+++ b/pkg/dartdoc/lib/dartdoc.dart
@@ -1083,28 +1083,28 @@ class Dartdoc {
if (member is MethodMirror) {
if (member.isGetter) {
instanceGetters[member.displayName] = member;
- if (member.surroundingDeclaration == host) {
+ if (member.owner == host) {
allPropertiesInherited = false;
}
} else if (member.isSetter) {
instanceSetters[member.displayName] = member;
- if (member.surroundingDeclaration == host) {
+ if (member.owner == host) {
allPropertiesInherited = false;
}
} else if (member.isOperator) {
instanceOperators.add(member);
- if (member.surroundingDeclaration == host) {
+ if (member.owner == host) {
allOperatorsInherited = false;
}
} else {
instanceMethods.add(member);
- if (member.surroundingDeclaration == host) {
+ if (member.owner == host) {
allMethodsInherited = false;
}
}
} else if (member is FieldMirror) {
instanceGetters[member.displayName] = member;
- if (member.surroundingDeclaration == host) {
+ if (member.owner == host) {
allPropertiesInherited = false;
}
}
@@ -1169,7 +1169,7 @@ class Dartdoc {
} else {
DocComment getterComment = getMemberComment(getter);
DocComment setterComment = getMemberComment(setter);
- if (getter.surroundingDeclaration !== setter.surroundingDeclaration ||
+ if (getter.owner !== setter.owner ||
getterComment != null && setterComment != null) {
// Both have comments or are not declared in the same class
// => Documents separately.
@@ -1240,7 +1240,7 @@ class Dartdoc {
}
bool showCode = includeSource && !isAbstract;
- bool inherited = host != member.surroundingDeclaration;
+ bool inherited = host != member.owner;
writeln('<div class="method${inherited ? ' inherited': ''}">'
'<h4 id="${memberAnchor(member)}">');
@@ -1294,7 +1294,7 @@ class Dartdoc {
if (inherited) {
write('<div class="inherited-from">inherited from ');
- annotateType(host, member.surroundingDeclaration);
+ annotateType(host, member.owner);
write('</div>');
}
@@ -1331,7 +1331,7 @@ class Dartdoc {
_totalMembers++;
_currentMember = getter;
- bool inherited = host != getter.surroundingDeclaration;
+ bool inherited = host != getter.owner;
writeln('<div class="field${inherited ? ' inherited' : ''}">'
'<h4 id="${memberAnchor(getter)}">');
@@ -1374,7 +1374,7 @@ class Dartdoc {
if (inherited) {
write('<div class="inherited-from">inherited from ');
- annotateType(host, getter.surroundingDeclaration);
+ annotateType(host, getter.owner);
write('</div>');
}
@@ -1477,9 +1477,9 @@ class Dartdoc {
String comment = _comments.find(member.location);
ClassMirror inheritedFrom = null;
if (comment == null) {
- if (member.surroundingDeclaration is ClassMirror) {
+ if (member.owner is ClassMirror) {
var iterable =
- new HierarchyIterable(member.surroundingDeclaration,
+ new HierarchyIterable(member.owner,
includeType: false);
for (ClassMirror type in iterable) {
var inheritedMember = type.declaredMembers[member.simpleName];
@@ -1539,7 +1539,7 @@ class Dartdoc {
/** Gets the URL for the documentation for [member]. */
String memberUrl(MemberMirror member) {
- String url = typeUrl(member.surroundingDeclaration);
+ String url = typeUrl(member.owner);
return '$url#${memberAnchor(member)}';
}
« no previous file with comments | « no previous file | pkg/dartdoc/lib/mirrors.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698