dart2js: keep track of non-final static fields.

dart2js: keep track of non-final static fields.

Dart2js used to just emit static non-final fields, even if they were not referenced.
This is bad, because in some cases it referenced a constant that didn't exist (was tree-shaken away). In the old emitter this just became a reference to a non-existing property, but in the new emitter it crashed.

This CL also fixes (partially) static non-final fields for the lazy emitter.

R=sra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45752

[floitsch, 2015-05-12 06:54:32]

floitsch@google.com changed reviewers:
+ herhut@google.com, sra@google.com

[sra1, 2015-05-12 23:20:02]

lgtm

https://chromiumcodereview.appspot.com/1132363003/diff/1/pkg/compiler/lib/src...
File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right):

https://chromiumcodereview.appspot.com/1132363003/diff/1/pkg/compiler/lib/src...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:458: 
FYI you could interpolate this with

js.statement('{ # # }', [...]);

Doing to will flatten blocks.

[floitsch, 2015-05-12 23:34:11]

https://chromiumcodereview.appspot.com/1132363003/diff/1/pkg/compiler/lib/src...
File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right):

https://chromiumcodereview.appspot.com/1132363003/diff/1/pkg/compiler/lib/src...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:458: 
On 2015/05/12 23:20:02, sra1 wrote:
> FYI you could interpolate this with
> 
> js.statement('{ # # }', [...]);
> 
> Doing to will flatten blocks.

Blocks are flattened by the JS pretty printer too.

[floitsch, 2015-05-12 23:34:56]

Committed patchset #1 (id:1) manually as 45752 (presubmit successful).