Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Unified Diff: pkg/compiler/lib/src/js_emitter/program_builder.dart

Issue 1132363003: dart2js: keep track of non-final static fields. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/program_builder.dart
diff --git a/pkg/compiler/lib/src/js_emitter/program_builder.dart b/pkg/compiler/lib/src/js_emitter/program_builder.dart
index 0b901412ee4ef0eb11f20b8a15237cb5429b5103..8b55f58ca95c810128231e62e3dd7851610a6a42 100644
--- a/pkg/compiler/lib/src/js_emitter/program_builder.dart
+++ b/pkg/compiler/lib/src/js_emitter/program_builder.dart
@@ -199,14 +199,11 @@ class ProgramBuilder {
}
List<StaticField> _buildStaticNonFinalFields(LibrariesMap librariesMap) {
- // TODO(floitsch): handle static non-final fields correctly with deferred
- // libraries.
- if (librariesMap != _registry.mainLibrariesMap) {
- return const <StaticField>[];
- }
- Iterable<VariableElement> staticNonFinalFields =
- backend.constants.getStaticNonFinalFieldsForEmission();
- return Elements.sortedByPosition(staticNonFinalFields)
+ List<VariableElement> staticNonFinalFields =
+ _task.outputStaticNonFinalFieldLists[librariesMap.outputUnit];
+ if (staticNonFinalFields == null) return const <StaticField>[];
+
+ return staticNonFinalFields
.map(_buildStaticField)
.toList(growable: false);
}

Powered by Google App Engine
This is Rietveld 408576698