Issue 1130973002: After sudying IrregExp compilation, it seems too complicated to do lazy local var descriptors for t…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1130973002: After sudying IrregExp compilation, it seems too complicated to do lazy local var descriptors for t… (Closed)

Created:
5 years, 7 months ago by srdjan

Modified:
5 years, 7 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

After sudying IrregExp compilation, it seems too complicated to do lazy local var descriptors for those. The amount of eagerly generated descriptors is small enough that it IMO does not warrant the additional complexity. Cleaned up, removed the flag. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=45631

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -11 lines)			Patch
	M	runtime/vm/flow_graph_compiler.cc	View	1 2 3	2 chunks	+4 lines, -7 lines	0 comments	Download
	M	runtime/vm/regexp.cc	View	1 2	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

hausner

I wonder whether var descriptors for regexp functions are all the same (since token position ...

5 years, 7 months ago (2015-05-07 16:08:39 UTC) #3

srdjan

5 years, 7 months ago (2015-05-08 07:04:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as r45631 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages