Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: runtime/vm/flow_graph_compiler.cc

Issue 1130973002: After sudying IrregExp compilation, it seems too complicated to do lazy local var descriptors for t… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/regexp.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler.cc
===================================================================
--- runtime/vm/flow_graph_compiler.cc (revision 45626)
+++ runtime/vm/flow_graph_compiler.cc (working copy)
@@ -928,7 +928,10 @@
}
LocalVarDescriptors& var_descs = LocalVarDescriptors::Handle();
if (parsed_function().node_sequence() == NULL) {
- // TODO(srdjan): Implement lazy local var descriptors if Irregexp functions.
+ // Eager local var descriptors computation for Irregexp function as it is
+ // complicated to factor out.
+ // TODO(srdjan): Consider canonicalizing and reusing the local var
+ // descriptor for IrregexpFunction.
ASSERT(flow_graph().IsIrregexpFunction());
var_descs = LocalVarDescriptors::New(1);
RawLocalVarDescriptors::VarInfo info;
@@ -938,12 +941,6 @@
info.end_pos = 0;
info.set_index(parsed_function().current_context_var()->index());
var_descs.SetVar(0, Symbols::CurrentContextVar(), &info);
- } else {
- if (FLAG_eager_info_computation) {
- var_descs =
- parsed_function_.node_sequence()->scope()->GetVarDescriptors(
- parsed_function_.function());
- }
}
code.set_var_descriptors(var_descs);
}
« no previous file with comments | « no previous file | runtime/vm/regexp.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698