Issue 11309011: Issue 4289. Separate optional positional and named parameters

Issue 11309011: Issue 4289. Separate optional positional and named parameters (Closed)

Created:
8 years, 1 month ago by scheglov

Modified:
8 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 4289. Separate optional positional and named parameters R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=14164

Patch Set 1 #

Total comments: 3

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+496 lines, -167 lines)			Patch
M	compiler/java/com/google/dart/compiler/ast/DartToSourceVisitor.java	View	2 chunks	+16 lines, -4 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/Elements.java	View	1 chunk	+15 lines, -1 line	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/ResolveVisitor.java	View	1 chunk	+8 lines, -3 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/Resolver.java	View	3 chunks	+26 lines, -12 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java	View	4 chunks	+6 lines, -3 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java	View	5 chunks	+168 lines, -70 lines	2 comments	Download
M	compiler/java/com/google/dart/compiler/type/Types.java	View	2 chunks	+46 lines, -14 lines	1 comment	Download
M	compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java	View	2 chunks	+14 lines, -2 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/resolver/ResolverCompilerTest.java	View	1 chunk	+68 lines, -9 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java	View	1 chunk	+19 lines, -5 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java	View	13 chunks	+104 lines, -35 lines	0 comments	Download
M	tests/co19/co19-compiler.status	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	tests/language/bad_named_parameters_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

8 years, 1 month ago (2012-10-27 00:09:39 UTC) #2

LGTM

https://codereview.chromium.org/11309011/diff/1/compiler/java/com/google/dart...
File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (right):

https://codereview.chromium.org/11309011/diff/1/compiler/java/com/google/dart...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:1174: //        //
Check positional arguments for named parameters.
Is there any reason not to delete the commented out code?

https://codereview.chromium.org/11309011/diff/1/compiler/java/com/google/dart...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:3396: //       
List<VariableElement> named = getNamedParameters(parameters);
Is there any reason not to delete the commented out code?

https://codereview.chromium.org/11309011/diff/1/compiler/java/com/google/dart...
File compiler/java/com/google/dart/compiler/type/Types.java (right):

https://codereview.chromium.org/11309011/diff/1/compiler/java/com/google/dart...
compiler/java/com/google/dart/compiler/type/Types.java:401: //     
Iterator<Entry<String, Type>> tList = tMap.entrySet().iterator();
Is there any reason not to delete the commented out code?

Expand Messages | Collapse Messages