Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1113)

Unified Diff: compiler/java/com/google/dart/compiler/resolver/Elements.java

Issue 11309011: Issue 4289. Separate optional positional and named parameters (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/compiler/resolver/Elements.java
diff --git a/compiler/java/com/google/dart/compiler/resolver/Elements.java b/compiler/java/com/google/dart/compiler/resolver/Elements.java
index de23bb95a57a417b0f287b4952445db006e78f33..ab79bb49ccbde3abeaa1f8a66d1e05cf925475e2 100644
--- a/compiler/java/com/google/dart/compiler/resolver/Elements.java
+++ b/compiler/java/com/google/dart/compiler/resolver/Elements.java
@@ -446,7 +446,21 @@ static FieldElementImplementation fieldFromNode(DartField node,
int num = 0;
List<VariableElement> parameters = method.getParameters();
for (VariableElement parameter : parameters) {
- if (!parameter.isNamed()) {
+ if (!parameter.isOptional() && !parameter.isNamed()) {
+ num++;
+ }
+ }
+ return num;
+ }
+
+ /**
+ * @return the number of optional positional parameters in given {@link MethodElement}.
+ */
+ public static int getNumberOfOptionalPositionalParameters(MethodElement method) {
+ int num = 0;
+ List<VariableElement> parameters = method.getParameters();
+ for (VariableElement parameter : parameters) {
+ if (parameter.isOptional()) {
num++;
}
}

Powered by Google App Engine
This is Rietveld 408576698