Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1130843002: Unify processing of Keywords and predefined symbols in the same loop and add accessors for keyword … (Closed)

Created:
5 years, 7 months ago by siva
Modified:
5 years, 7 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Unify processing of Keywords and predefined symbols in the same loop and add accessors for keyword symbol handles. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=45602

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -18 lines) Patch
M runtime/vm/symbols.h View 2 chunks +12 lines, -5 lines 0 comments Download
M runtime/vm/symbols.cc View 3 chunks +7 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
siva
5 years, 7 months ago (2015-05-06 17:23:59 UTC) #2
hausner
LGTM.
5 years, 7 months ago (2015-05-06 18:27:44 UTC) #3
siva
5 years, 7 months ago (2015-05-07 17:28:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r45602 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698