Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Unified Diff: runtime/vm/symbols.h

Issue 1130843002: Unify processing of Keywords and predefined symbols in the same loop and add accessors for keyword … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/symbols.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/symbols.h
===================================================================
--- runtime/vm/symbols.h (revision 45570)
+++ runtime/vm/symbols.h (working copy)
@@ -396,13 +396,13 @@
#define DEFINE_SYMBOL_INDEX(symbol, literal) \
k##symbol##Id,
-PREDEFINED_SYMBOLS_LIST(DEFINE_SYMBOL_INDEX)
+ PREDEFINED_SYMBOLS_LIST(DEFINE_SYMBOL_INDEX)
#undef DEFINE_SYMBOL_INDEX
kKwTableStart, // First keyword at kKwTableStart + 1.
-#define DEFINE_KEYWORD_SYMBOL_INDEX(token, chars, ignore1, ignore2) \
- token##Id,
+#define DEFINE_KEYWORD_SYMBOL_INDEX(t, s, p, a) \
+ t##Id,
DART_KEYWORD_LIST(DEFINE_KEYWORD_SYMBOL_INDEX)
#undef DEFINE_KEYWORD_SYMBOL_INDEX
@@ -514,12 +514,19 @@
static const String& True() { return *(symbol_handles_[kTRUEId]); }
static const String& Void() { return *(symbol_handles_[kVOIDId]); }
- // Access methods for symbol handles stored in the vm isolate.
+ // Access methods for symbol handles stored in the vm isolate for predefined
+ // symbols.
#define DEFINE_SYMBOL_HANDLE_ACCESSOR(symbol, literal) \
static const String& symbol() { return *(symbol_handles_[k##symbol##Id]); }
-PREDEFINED_SYMBOLS_LIST(DEFINE_SYMBOL_HANDLE_ACCESSOR)
+ PREDEFINED_SYMBOLS_LIST(DEFINE_SYMBOL_HANDLE_ACCESSOR)
#undef DEFINE_SYMBOL_HANDLE_ACCESSOR
+ // Access methods for symbol handles stored in the vm isolate for keywords.
+#define DEFINE_SYMBOL_HANDLE_ACCESSOR(t, s, p, a) \
+ static const String& t() { return *(symbol_handles_[t##Id]); }
+ DART_KEYWORD_LIST(DEFINE_SYMBOL_HANDLE_ACCESSOR)
+#undef DEFINE_SYMBOL_HANDLE_ACCESSOR
+
// Get symbol for scanner keyword.
static const String& Keyword(Token::Kind keyword);
« no previous file with comments | « no previous file | runtime/vm/symbols.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698