Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 11308110: Add TODOs about narrowing JSON catch clauses to the OAuth2 package. (Closed)

Created:
8 years, 1 month ago by nweiz
Modified:
8 years, 1 month ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add TODOs about narrowing JSON catch clauses to the OAuth2 package. Committed: https://code.google.com/p/dart/source/detail?r=15120

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M pkg/oauth2/lib/src/credentials.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/oauth2/lib/src/handle_access_token_response.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
nweiz
8 years, 1 month ago (2012-11-19 23:01:00 UTC) #1
Bob Nystrom
8 years, 1 month ago (2012-11-19 23:15:57 UTC) #2
LGTM, thanks for doing this!

Powered by Google App Engine
This is Rietveld 408576698