pkg/oauth2/lib/src/credentials.dart - Issue 11308110: Add TODOs about narrowing JSON catch clauses to the OAuth2 package.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/oauth2/lib/src/credentials.dart

Issue 11308110: Add TODOs about narrowing JSON catch clauses to the OAuth2 package. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/oauth2/lib/src/credentials.dart

diff --git a/pkg/oauth2/lib/src/credentials.dart b/pkg/oauth2/lib/src/credentials.dart

index f0939c9c20e6b04d8a28f508c33f85256101ca9a..1a358273eb0027630230498995e17b594bd59baa 100644

--- a/pkg/oauth2/lib/src/credentials.dart

+++ b/pkg/oauth2/lib/src/credentials.dart

@@ -80,6 +80,7 @@ class Credentials {

try {

parsed = JSON.parse(json);

} catch (e) {

+ // TODO(nweiz): narrow this catch clause once issue 6775 is fixed.

validate(false, 'invalid JSON');

}

« no previous file with comments | « no previous file | pkg/oauth2/lib/src/handle_access_token_response.dart » ('j') | no next file with comments »