Add HttpsServer class and test.

Add HttpsServer class and test.


BUG=dart:3593
Committed: https://code.google.com/p/dart/source/detail?r=15452

[Søren Gjesse, 2012-11-28 15:21:49]

lgtm

https://codereview.chromium.org/11299228/diff/2001/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/11299228/diff/2001/sdk/lib/io/http_impl.dart#...
sdk/lib/io/http_impl.dart:954: void listenOn(ServerSocket serverSocket) {
We should check that the type of the ServerSocket is the expected one.

[Bill Hesse, 2012-11-28 15:39:40]

https://codereview.chromium.org/11299228/diff/2001/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/11299228/diff/2001/sdk/lib/io/http_impl.dart#...
sdk/lib/io/http_impl.dart:954: void listenOn(ServerSocket serverSocket) {
On 2012/11/28 15:21:49, Søren Gjesse wrote:
> We should check that the type of the ServerSocket is the expected one.

Done.

[Mads Ager (google), 2012-11-29 09:45:24]

This is good as a start, but I think we should split out the abstract classes so
that there is an HTTPS-specific listen method. We should probably have a
HTTPS-specific listenOn method as well that has the right type (SecureSocket)
for the socket so the editor and checked mode can help check the code.

https://codereview.chromium.org/11299228/diff/6001/sdk/lib/io/http.dart
File sdk/lib/io/http.dart (right):

https://codereview.chromium.org/11299228/diff/6001/sdk/lib/io/http.dart#newco...
sdk/lib/io/http.dart:71: void listen(String host,
When we are splitting out the abstract classes I don't think it makes sense to
have a certificate_name in this interface.

Can we split this out so that there is an HttpServerBase that has everything
that is shared. Then HttpServer implements HttpServerBase and has the listen
method without the certificate_name and HttpsServer has the listen method with
the certificate_name (as a required parameter?).

https://codereview.chromium.org/11299228/diff/6001/sdk/lib/io/http.dart#newco...
sdk/lib/io/http.dart:74: String certificate_name});
I would indent this line by one more char, but that is personal style:

{int backlog: 128
 String certificate_name});

https://codereview.chromium.org/11299228/diff/6001/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/11299228/diff/6001/sdk/lib/io/http_impl.dart#...
sdk/lib/io/http_impl.dart:931: class _HttpServer implements HttpServer,
HttpsServer {
Similarly here in the implementation. It might be nice to have a base class for
the shared functionality and have separate listen and listenOn methods.