Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1299)

Unified Diff: sdk/lib/io/http.dart

Issue 11299228: Add HttpsServer class and test. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Adress comment Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/io/http_impl.dart » ('j') | sdk/lib/io/http_impl.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/io/http.dart
diff --git a/sdk/lib/io/http.dart b/sdk/lib/io/http.dart
index 02ab0ac8f08428911770f19b4e2fcab92214b5b8..5c8a2f02a8c295765ebb27a3c33e2fe5fb9527b3 100644
--- a/sdk/lib/io/http.dart
+++ b/sdk/lib/io/http.dart
@@ -62,11 +62,16 @@ abstract class HttpServer {
* Start listening for HTTP requests on the specified [host] and
* [port]. If a [port] of 0 is specified the server will choose an
* ephemeral port. The optional argument [backlog] can be used to
- * specify the listen backlog for the underlying OS listen
- * setup. See [addRequestHandler] and [defaultRequestHandler] for
+ * specify the listen backlog for the underlying OS listen.
+ * The optional argument [certificate_name] is used by the HttpsServer
+ * class, which shares the same interface.
+ * See [addRequestHandler] and [defaultRequestHandler] for
* information on how incoming HTTP requests are handled.
*/
- void listen(String host, int port, {int backlog: 128});
+ void listen(String host,
Mads Ager (google) 2012/11/29 09:45:24 When we are splitting out the abstract classes I d
+ int port,
+ {int backlog: 128,
+ String certificate_name});
Mads Ager (google) 2012/11/29 09:45:24 I would indent this line by one more char, but tha
/**
* Attach the HTTP server to an existing [:ServerSocket:]. If the
@@ -127,6 +132,14 @@ abstract class HttpServer {
/**
+ * HTTPS server.
+ */
+abstract class HttpsServer implements HttpServer {
+ factory HttpsServer() => new _HttpServer.httpsServer();
+}
+
+
+/**
* Overview information of the [:HttpServer:] socket connections.
*/
class HttpConnectionsInfo {
« no previous file with comments | « no previous file | sdk/lib/io/http_impl.dart » ('j') | sdk/lib/io/http_impl.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698