Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 112953004: Work around issue 15920 in pkg/stack_trace. (Closed)

Created:
6 years, 11 months ago by nweiz
Modified:
6 years, 11 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Work around issue 15920 in pkg/stack_trace. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=31526

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M pkg/stack_trace/lib/src/trace.dart View 1 chunk +4 lines, -1 line 2 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
6 years, 11 months ago (2014-01-06 21:23:51 UTC) #1
Bob Nystrom
https://codereview.chromium.org/112953004/diff/1/pkg/stack_trace/lib/src/trace.dart File pkg/stack_trace/lib/src/trace.dart (right): https://codereview.chromium.org/112953004/diff/1/pkg/stack_trace/lib/src/trace.dart#newcode131 pkg/stack_trace/lib/src/trace.dart:131: where((line) => line.isNotEmpty). Should you trim the line first ...
6 years, 11 months ago (2014-01-06 21:42:49 UTC) #2
nweiz
https://codereview.chromium.org/112953004/diff/1/pkg/stack_trace/lib/src/trace.dart File pkg/stack_trace/lib/src/trace.dart (right): https://codereview.chromium.org/112953004/diff/1/pkg/stack_trace/lib/src/trace.dart#newcode131 pkg/stack_trace/lib/src/trace.dart:131: where((line) => line.isNotEmpty). On 2014/01/06 21:42:49, Bob Nystrom wrote: ...
6 years, 11 months ago (2014-01-06 23:59:27 UTC) #3
Bob Nystrom
lgtm
6 years, 11 months ago (2014-01-07 00:34:02 UTC) #4
nweiz
6 years, 11 months ago (2014-01-07 00:39:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r31526 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698