Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: pkg/stack_trace/lib/src/trace.dart

Issue 112953004: Work around issue 15920 in pkg/stack_trace. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/stack_trace/lib/src/trace.dart
diff --git a/pkg/stack_trace/lib/src/trace.dart b/pkg/stack_trace/lib/src/trace.dart
index 88b9275182b64262268c3a2c6ba892ad99754e66..45cb42c757a2e295631b8ce5d7d91c1c49c851f0 100644
--- a/pkg/stack_trace/lib/src/trace.dart
+++ b/pkg/stack_trace/lib/src/trace.dart
@@ -126,7 +126,10 @@ class Trace implements StackTrace {
/// Parses a string representation of a Dart VM stack trace.
Trace.parseVM(String trace)
- : this(trace.trim().split("\n").map((line) => new Frame.parseVM(line)));
+ : this(trace.trim().split("\n").
+ // TODO(nweiz): remove this when issue 15920 is fixed.
+ where((line) => line.isNotEmpty).
Bob Nystrom 2014/01/06 21:42:49 Should you trim the line first in case it contains
nweiz 2014/01/06 23:59:27 I'm pretty sure that in practice the blank lines p
+ map((line) => new Frame.parseVM(line)));
/// Parses a string representation of a Chrome/V8 stack trace.
Trace.parseV8(String trace)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698