Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 11293290: Fix native argument handling (Closed)

Created:
8 years, 1 month ago by hausner
Modified:
8 years, 1 month ago
Reviewers:
siva, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix native argument handling Native functions need to fetch arguments differently if they are called through a closure. fixes issue 6696. Committed: https://code.google.com/p/dart/source/detail?r=14937

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+362 lines, -342 lines) Patch
M runtime/lib/array.cc View 4 chunks +13 lines, -13 lines 0 comments Download
M runtime/lib/byte_array.cc View 13 chunks +21 lines, -21 lines 0 comments Download
M runtime/lib/date.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/lib/double.cc View 15 chunks +42 lines, -40 lines 0 comments Download
M runtime/lib/error.cc View 5 chunks +16 lines, -12 lines 0 comments Download
M runtime/lib/growable_array.cc View 5 chunks +13 lines, -13 lines 0 comments Download
M runtime/lib/integers.cc View 15 chunks +27 lines, -27 lines 0 comments Download
M runtime/lib/isolate.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M runtime/lib/math.cc View 3 chunks +13 lines, -13 lines 0 comments Download
M runtime/lib/mirrors.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/object.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M runtime/lib/regexp.cc View 3 chunks +14 lines, -13 lines 0 comments Download
M runtime/lib/string.cc View 6 chunks +16 lines, -15 lines 0 comments Download
M runtime/lib/weak_property.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/code_generator.cc View 36 chunks +117 lines, -112 lines 0 comments Download
M runtime/vm/compiler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +4 lines, -25 lines 0 comments Download
M runtime/vm/exceptions_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/native_arguments.h View 2 chunks +31 lines, -3 lines 0 comments Download
M runtime/vm/native_entry.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/runtime_entry_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/stack_frame_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/language.status View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
hausner
8 years, 1 month ago (2012-11-15 00:29:17 UTC) #1
siva
lgtm
8 years, 1 month ago (2012-11-15 01:09:20 UTC) #2
hausner
Thank you!
8 years, 1 month ago (2012-11-15 01:19:39 UTC) #3
Ivan Posva
Matthias, Does the normal native method handling not suffer from this problem? -Ivan
8 years, 1 month ago (2012-11-15 07:56:55 UTC) #4
hausner
If by 'normal' you mean not closurized, then no, the problem does not exist in ...
8 years, 1 month ago (2012-11-15 16:48:17 UTC) #5
Ivan Posva
On 2012/11/15 16:48:17, hausner wrote: > If by 'normal' you mean not closurized, then no, ...
8 years, 1 month ago (2012-11-15 17:27:26 UTC) #6
hausner
8 years, 1 month ago (2012-11-15 17:31:57 UTC) #7
Those methods I assume use Dart_GetNativeArgument() API to get their parameters,
in which case they are fine.

Powered by Google App Engine
This is Rietveld 408576698