Fix native argument handling

runtime/vm/dart_api_impl.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/dart.h"
@@ skipping 3921 matching lines @@
   return Api::NewError("Exception was not re thrown, internal error");
 }
 
 
 // --- Native functions ---
 
 
 DART_EXPORT Dart_Handle Dart_GetNativeArgument(Dart_NativeArguments args,
                                                int index) {
   NativeArguments* arguments = reinterpret_cast<NativeArguments*>(args);
-  const int apparent_count = Dart_GetNativeArgumentCount(args);
-  if ((index < 0) || (index >= apparent_count)) {
+  if ((index < 0) || (index >= arguments->NativeArgCount())) {
     return Api::NewError(
         "%s: argument 'index' out of range. Expected 0..%d but saw %d.",
-        CURRENT_FUNC, apparent_count - 1, index);
+        CURRENT_FUNC, arguments->NativeArgCount() - 1, index);
   }
-  // Hide closure object if present.
-  index += arguments->Count() - apparent_count;
-
-  Isolate* isolate = arguments->isolate();
-  CHECK_ISOLATE(isolate);
-  if (index == 0) {
-    if (arguments->ToInstanceFunction() && arguments->ToClosureFunction()) {
-      // Retrieve the receiver from the context.
-      const Context& context = Context::Handle(isolate->top_context());
-      return Api::NewHandle(isolate, context.At(0));
-    }
-  }
-  return Api::NewHandle(isolate, arguments->At(index));
+  return Api::NewHandle(arguments->isolate(), arguments->NativeArgAt(index));
 }
 
 
 DART_EXPORT int Dart_GetNativeArgumentCount(Dart_NativeArguments args) {
   NativeArguments* arguments = reinterpret_cast<NativeArguments*>(args);
-  int count = arguments->Count();
-  // In the instance closure function case, the receiver is accessed from
-  // the context and the closure at index 0 is hidden, so the apparent
-  // argument count remains unchanged.
-  if (arguments->ToClosureFunction() && !arguments->ToInstanceFunction()) {
-    // The closure at index 0 is hidden and therefore not counted.
-    count--;
-  }
-  return count;
+  return arguments->NativeArgCount();
 }
 
 
 // This function has friend access to SetReturnUnsafe.
 void SetReturnValueHelper(Dart_NativeArguments args, Dart_Handle retval) {
   NoGCScope no_gc_scope;
   NativeArguments* arguments = reinterpret_cast<NativeArguments*>(args);
   arguments->SetReturnUnsafe(Api::UnwrapHandle(retval));
 }
 
@@ skipping 481 matching lines @@
   }
   {
     NoGCScope no_gc;
     RawObject* raw_obj = obj.raw();
     isolate->heap()->SetPeer(raw_obj, peer);
   }
   return Api::Success(isolate);
 }
 
 }  // namespace dart