Issue 11293272: Update dart2js_foreign suite as we now validate annotations.

Issue 11293272: Update dart2js_foreign suite as we now validate annotations. (Closed)

Created:
8 years, 1 month ago by ahe

Modified:
8 years, 1 month ago

Reviewers:
ricow1, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Update dart2js_foreign suite as we now validate annotations. Committed: https://code.google.com/p/dart/source/detail?r=14885

Patch Set 1 #

Total comments: 2

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+232 lines, -147 lines)			Patch
M	dart/tests/compiler/dart2js_foreign/foreign_test.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_call_arity1_test.dart	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_call_arity2_test.dart	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_call_arity3_test.dart	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_checked_arguments1_test.dart	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_checked_fields_test.dart	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_class_avoids_hidden_name_test.dart	View	3 chunks	+6 lines, -4 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_class_inheritance1_test.dart	View	3 chunks	+7 lines, -5 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_class_inheritance2_test.dart	View	2 chunks	+7 lines, -5 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_class_inheritance3_test.dart	View	3 chunks	+7 lines, -5 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_class_inheritance4_test.dart	View	3 chunks	+5 lines, -3 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_class_is_check1_test.dart	View	3 chunks	+4 lines, -2 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_class_is_check3_test.dart	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_class_with_dart_methods_test.dart	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_closure_identity_test.dart	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_exceptions1_test.dart	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_field_rename_1_test.dart	View	3 chunks	+6 lines, -4 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_field_rename_2_test.dart	View	2 chunks	+7 lines, -5 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_library_same_name_used_lib2.dart	View	1 chunk	+1 line, -1 line	2 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_library_same_name_used_test.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_literal_class_test.dart	View	1 chunk	+4 lines, -2 lines	0 comments	Download
A +	dart/tests/compiler/dart2js_foreign/native_metadata.dart	View	1 chunk	+6 lines, -5 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_method_rename1_test.dart	View	2 chunks	+7 lines, -5 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_method_rename2_test.dart	View	1 chunk	+7 lines, -5 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_method_rename3_test.dart	View	2 chunks	+7 lines, -5 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_method_with_keyword_name_test.dart	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_missing_method1_test.dart	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_missing_method2_test.dart	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_named_constructors2_test.dart	View	1 chunk	+5 lines, -4 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_named_constructors3_test.dart	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_no_such_method_exception2_test.dart	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_no_such_method_exception3_test.dart	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_no_such_method_exception4_test.dart	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_no_such_method_exception5_test.dart	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_no_such_method_exception_test.dart	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_null_closure_test.dart	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_null_test.dart	View	1 chunk	+8 lines, -6 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_parameter_names_test.dart	View	1 chunk	+6 lines, -4 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_property_test.dart	View	2 chunks	+8 lines, -6 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_to_string_test.dart	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_use_native_name_in_table_test.dart	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_window1_test.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_window2_test.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_wrapping_function2_test.dart	View	1 chunk	+8 lines, -6 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_wrapping_function3_test.dart	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	dart/tests/compiler/dart2js_foreign/native_wrapping_function_test.dart	View	2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ricow1

LGTM https://codereview.chromium.org/11293272/diff/1/dart/tests/compiler/dart2js_foreign/native_library_same_name_used_lib2.dart File dart/tests/compiler/dart2js_foreign/native_library_same_name_used_lib2.dart (right): https://codereview.chromium.org/11293272/diff/1/dart/tests/compiler/dart2js_foreign/native_library_same_name_used_lib2.dart#newcode9 dart/tests/compiler/dart2js_foreign/native_library_same_name_used_lib2.dart:9: Don't we need: import 'native_metadata.dart'; here?

8 years, 1 month ago (2012-11-14 12:36:21 UTC) #4

ahe

8 years, 1 month ago (2012-11-14 14:38:40 UTC) #5

Thank you for the review.  I know it was boring :-)

https://codereview.chromium.org/11293272/diff/1/dart/tests/compiler/dart2js_f...
File dart/tests/compiler/dart2js_foreign/native_library_same_name_used_lib2.dart
(right):

https://codereview.chromium.org/11293272/diff/1/dart/tests/compiler/dart2js_f...
dart/tests/compiler/dart2js_foreign/native_library_same_name_used_lib2.dart:9: 
On 2012/11/14 12:36:21, ricow1 wrote:
> Don't we need:
> import 'native_metadata.dart';
> here?

Filed http://dartbug.com/6720 as I'm upgrading my OS right now and only have a
chromebook.

Expand Messages | Collapse Messages