dart/tests/compiler/dart2js_foreign/native_class_avoids_hidden_name_test.dart - Issue 11293272: Update dart2js_foreign suite as we now validate annotations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/tests/compiler/dart2js_foreign/native_class_avoids_hidden_name_test.dart

Issue 11293272: Update dart2js_foreign suite as we now validate annotations. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « dart/tests/compiler/dart2js_foreign/native_checked_fields_test.dart ('k') | dart/tests/compiler/dart2js_foreign/native_class_inheritance1_test.dart » ('j') | dart/tests/compiler/dart2js_foreign/native_library_same_name_used_lib2.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/tests/compiler/dart2js_foreign/native_class_avoids_hidden_name_test.dart

diff --git a/dart/tests/compiler/dart2js_foreign/native_class_avoids_hidden_name_test.dart b/dart/tests/compiler/dart2js_foreign/native_class_avoids_hidden_name_test.dart

index b9d0ff2af262d4057672ff6074ce35bd50d5cfc0..170d6e22cffecba006715a5a6eea7fca00e5ab6d 100644

--- a/dart/tests/compiler/dart2js_foreign/native_class_avoids_hidden_name_test.dart

+++ b/dart/tests/compiler/dart2js_foreign/native_class_avoids_hidden_name_test.dart

@@ -4,13 +4,15 @@

// Test that hidden native class names are not used by generated code.

-@native("*B")

+import 'native_metadata.dart';

+@Native("*B")

class A {

get name => 'A';

static A create() => makeA();

}

-@native("*C")

+@Native("*C")

class B {

get name => 'B';

static B create() => makeB();

@@ -24,7 +26,7 @@ class C { // Ordinary class with name clashing with native class.

@native makeA();

@native makeB();

-@native("""

+@Native("""

// Poison hidden native names 'B' and 'C' to prove the compiler didn't place

// anthing on the hidden native class.

B = null;

@@ -32,7 +34,7 @@ C = null;

""")

void setup1();

-@native("""

+@Native("""

// This code is all inside 'setup' and so not accesible from the global scope.

function B(){}

function C(){}