Issue 11293058: Issue 5157. Introduce TypeQuality. Try to find member in subclasses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11293058: Issue 5157. Introduce TypeQuality. Try to find member in subclasses. (Closed)

Created:
8 years, 1 month ago by scheglov

Modified:
8 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 5157. Introduce TypeQuality. Try to find member in subclasses. http://code.google.com/p/dart/issues/detail?id=5157 R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=14480

Patch Set 1 #

Total comments: 1

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+446 lines, -243 lines)			Patch
M	compiler/java/com/google/dart/compiler/resolver/ClassElementImplementation.java	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/Resolver.java	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	compiler/java/com/google/dart/compiler/type/AbstractType.java	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/type/DynamicTypeImplementation.java	View	2 chunks	+14 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/type/InterfaceType.java	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/type/InterfaceTypeImplementation.java	View	4 chunks	+33 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/type/InterfaceTypeUnion.java	View	2 chunks	+15 lines, -2 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/type/Type.java	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java	View	18 chunks	+99 lines, -28 lines	1 comment	Download
M	compiler/java/com/google/dart/compiler/type/Types.java	View	4 chunks	+45 lines, -11 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/CompilerTestCase.java	View	3 chunks	+7 lines, -11 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java	View	2 chunks	+12 lines, -11 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java	View	64 chunks	+202 lines, -174 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

8 years, 1 month ago (2012-11-02 14:00:35 UTC) #2

LGTM

https://codereview.chromium.org/11293058/diff/1/compiler/java/com/google/dart...
File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (right):

https://codereview.chromium.org/11293058/diff/1/compiler/java/com/google/dart...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:3560: private
static boolean isExclicitlySpecifiedType(Type type) {
nit: "Exclicitly" --> "Explicitly"

Expand Messages | Collapse Messages