compiler/java/com/google/dart/compiler/resolver/Resolver.java - Issue 11293058: Issue 5157. Introduce TypeQuality. Try to find member in subclasses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/Resolver.java

Issue 11293058: Issue 5157. Introduce TypeQuality. Try to find member in subclasses. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/resolver/ClassElementImplementation.java ('k') | compiler/java/com/google/dart/compiler/type/AbstractType.java » ('j') | compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/resolver/Resolver.java

diff --git a/compiler/java/com/google/dart/compiler/resolver/Resolver.java b/compiler/java/com/google/dart/compiler/resolver/Resolver.java

index 9edadea0aac639b8ae2c4ed0094ce0f677dfc9f0..fb43f949ee5105e03a8488c9c3164ac1480b66fb 100644

--- a/compiler/java/com/google/dart/compiler/resolver/Resolver.java

+++ b/compiler/java/com/google/dart/compiler/resolver/Resolver.java

@@ -81,7 +81,9 @@ import com.google.dart.compiler.resolver.LabelElement.LabeledStatementType;

import com.google.dart.compiler.type.InterfaceType;

import com.google.dart.compiler.type.InterfaceType.Member;

import com.google.dart.compiler.type.Type;

+import com.google.dart.compiler.type.TypeAnalyzer;

import com.google.dart.compiler.type.TypeKind;

+import com.google.dart.compiler.type.TypeQuality;

import com.google.dart.compiler.type.TypeVariable;

import com.google.dart.compiler.type.Types;

@@ -726,7 +728,8 @@ public class Resolver {

Element element = node.getElement();

Type expressionType = expression.getType();

if (isFinal && expressionType != null && TypeKind.of(element.getType()) == TypeKind.DYNAMIC) {

- Type fieldType = Types.makeInferred(expressionType);

+ TypeQuality typeQuality = TypeAnalyzer.getTypeQuality(expression);

+ Type fieldType = Types.makeInferred(expressionType, typeQuality);

Elements.setType(element, fieldType);

}

} else if (isFinal) {