Issue 11280085: Add --checked or --minified to test directory name when generating output.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11280085: Add --checked or --minified to test directory name when generating output. (Closed)

Created:
8 years, 1 month ago by ricow1

Modified:
8 years ago

Reviewers:
ahe, ngeoffray, kustermann

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add --checked or --minified to test directory name when generating output. Currently the compiled output will simply be overwritten if you run non-checked mode followed by checked mode. Committed: https://code.google.com/p/dart/source/detail?r=15503

Patch Set 1 #

Total comments: 2

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	tools/testing/dart/test_suite.dart	View		1 chunk	+7 lines, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://codereview.chromium.org/11280085/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://codereview.chromium.org/11280085/diff/1/tools/testing/dart/test_suite.dart#newcode1039 tools/testing/dart/test_suite.dart:1039: var minified = configuration['minified'] ? '-minified' : ''; ...

8 years, 1 month ago (2012-11-20 10:32:28 UTC) #3

ricow1

8 years ago (2012-11-26 13:27:23 UTC) #4

https://codereview.chromium.org/11280085/diff/1/tools/testing/dart/test_suite...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/11280085/diff/1/tools/testing/dart/test_suite...
tools/testing/dart/test_suite.dart:1039: var minified =
configuration['minified'] ? '-minified' : '';
On 2012/11/20 10:32:28, ngeoffray wrote:
> Is configuration the list of flags passed to the compiler? Should you use that
> list then, instead of explicitly using some of the flags?
No it is not, configuration is a ton of stuff

Expand Messages | Collapse Messages