Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 11280085: Add --checked or --minified to test directory name when generating output. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
===================================================================
--- tools/testing/dart/test_suite.dart (revision 15134)
+++ tools/testing/dart/test_suite.dart (working copy)
@@ -1033,10 +1033,16 @@
// Create '[build dir]/generated_tests/$compiler-$runtime/$testUniqueName',
// including any intermediate directories that don't exist.
+ // If the tests are run in checked or minified mode we add that to the
+ // '$compile-$runtime' directory name.
+ var checked = configuration['checked'] ? '-checked' : '';
+ var minified = configuration['minified'] ? '-minified' : '';
ngeoffray 2012/11/20 10:32:28 Is configuration the list of flags passed to the c
ricow1 2012/11/26 13:27:23 No it is not, configuration is a ton of stuff
+ var dirName = "${configuration['compiler']}-${configuration['runtime']}"
+ "$checked$minified";
var generatedTestPath = Strings.join([
buildDir,
'generated_tests',
- "${configuration['compiler']}-${configuration['runtime']}",
+ dirName,
testUniqueName
], '/');
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698