Issue 11280018: Remove support for old package layouts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11280018: Remove support for old package layouts. (Closed)

Created:
8 years, 1 month ago by Bob Nystrom

Modified:
8 years, 1 month ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove support for old package layouts. Committed: https://code.google.com/p/dart/source/detail?r=14990

Patch Set 2 : Better error message. #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -68 lines)			Patch
	M	utils/pub/io.dart	View	1	1 chunk	+19 lines, -48 lines	0 comments	Download
	M	utils/tests/pub/install/pub_install_test.dart	View	1	2 chunks	+2 lines, -20 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

lgtm https://codereview.chromium.org/11280018/diff/1/utils/pub/io.dart File utils/pub/io.dart (right): https://codereview.chromium.org/11280018/diff/1/utils/pub/io.dart#newcode339 utils/pub/io.dart:339: 'Warning: Package "$name" does not have a "lib" ...

8 years, 1 month ago (2012-11-16 00:16:21 UTC) #2

Bob Nystrom

8 years, 1 month ago (2012-11-16 00:23:45 UTC) #3

Thanks!

https://codereview.chromium.org/11280018/diff/1/utils/pub/io.dart
File utils/pub/io.dart (right):

https://codereview.chromium.org/11280018/diff/1/utils/pub/io.dart#newcode339
utils/pub/io.dart:339: 'Warning: Package "$name" does not have a "lib"
directory.');
On 2012/11/16 00:16:21, nweiz wrote:
> Maybe also explain that you aren't creating a link in packages because of
this?

Done.

Expand Messages | Collapse Messages

Issue 11280018: Remove support for old package layouts. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Better error message. #

Messages