Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: utils/tests/pub/install/pub_install_test.dart

Issue 11280018: Remove support for old package layouts. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Better error message. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « utils/pub/io.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library pub_tests; 5 library pub_tests;
6 6
7 import 'dart:io'; 7 import 'dart:io';
8 8
9 import '../test_pub.dart'; 9 import '../test_pub.dart';
10 import '../../../../pkg/unittest/lib/unittest.dart'; 10 import '../../../../pkg/unittest/lib/unittest.dart';
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 ]) 82 ])
83 ]) 83 ])
84 ]).scheduleCreate(); 84 ]).scheduleCreate();
85 85
86 dir(appPath, [ 86 dir(appPath, [
87 pubspec({"name": "myapp", "dependencies": {"foo": {"sdk": "foo"}}}) 87 pubspec({"name": "myapp", "dependencies": {"foo": {"sdk": "foo"}}})
88 ]).scheduleCreate(); 88 ]).scheduleCreate();
89 89
90 schedulePub(args: ['install'], 90 schedulePub(args: ['install'],
91 error: new RegExp(r'Warning: Package "foo" does not have a "lib" ' 91 error: new RegExp(r'Warning: Package "foo" does not have a "lib" '
92 'directory.'), 92 'directory so you will not be able to import any libraries from '
93 'it.'),
93 output: new RegExp(r"Dependencies installed!$")); 94 output: new RegExp(r"Dependencies installed!$"));
94 95
95 run(); 96 run();
96 }); 97 });
97 98
98 test('does not warn if the root package lacks a "lib" directory', () { 99 test('does not warn if the root package lacks a "lib" directory', () {
99 dir(appPath, [ 100 dir(appPath, [
100 appPubspec([]) 101 appPubspec([])
101 ]).scheduleCreate(); 102 ]).scheduleCreate();
102 103
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
265 dir("myapp", [ 266 dir("myapp", [
266 file('foo.dart', 'main() => "foo";') 267 file('foo.dart', 'main() => "foo";')
267 ]) 268 ])
268 ]) 269 ])
269 ]) 270 ])
270 ]).scheduleValidate(); 271 ]).scheduleValidate();
271 272
272 run(); 273 run();
273 }); 274 });
274 }); 275 });
275
276 // TODO(rnystrom): Remove this when old layout support is removed. (#4964)
277 test('shows a warning if the entrypoint uses the old layout', () {
278 // The symlink should use the name in the pubspec, not the name of the
279 // directory.
280 dir(appPath, [
281 pubspec({"name": "myapp_name"}),
282 file("foo.dart", 'main() => "foo";'),
283 ]).scheduleCreate();
284
285 schedulePub(args: ['install'],
286 error: '''
287 Warning: Package "myapp_name" is using a deprecated layout.
288 See http://www.dartlang.org/docs/pub-package-manager/package-layout.html for details.
289 ''',
290 output: new RegExp(r"Dependencies installed!$"));
291
292 run();
293 });
294 } 276 }
OLDNEW
« no previous file with comments | « utils/pub/io.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698