Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1127693003: Fix analyzer warnings in service tests (Closed)

Created:
5 years, 7 months ago by Cutch
Modified:
5 years, 7 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fix analyzer warnings in service tests BUG= R=turnidge@google.com Committed: https://code.google.com/p/dart/source/detail?r=45511

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -23 lines) Patch
M runtime/observatory/tests/service/evaluate_activation_test.dart View 1 4 chunks +14 lines, -1 line 0 comments Download
M runtime/observatory/tests/service/gc_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/observatory/tests/service/get_allocation_profile_rpc_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/get_flag_list_rpc_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/get_heap_map_rpc_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/get_instances_rpc_test.dart View 1 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/get_isolate_rpc_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/get_object_rpc_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/get_retained_size_rpc_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/get_retaining_path_rpc_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/get_stack_rpc_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/get_vm_rpc_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
5 years, 7 months ago (2015-05-04 21:00:11 UTC) #2
turnidge
LGTM Thank you. https://codereview.chromium.org/1127693003/diff/1/runtime/observatory/tests/service/get_instances_rpc_test.dart File runtime/observatory/tests/service/get_instances_rpc_test.dart (left): https://codereview.chromium.org/1127693003/diff/1/runtime/observatory/tests/service/get_instances_rpc_test.dart#oldcode6 runtime/observatory/tests/service/get_instances_rpc_test.dart:6: import 'dart:async'; Kill one more blank ...
5 years, 7 months ago (2015-05-04 21:02:03 UTC) #3
Cutch
https://codereview.chromium.org/1127693003/diff/1/runtime/observatory/tests/service/get_instances_rpc_test.dart File runtime/observatory/tests/service/get_instances_rpc_test.dart (left): https://codereview.chromium.org/1127693003/diff/1/runtime/observatory/tests/service/get_instances_rpc_test.dart#oldcode6 runtime/observatory/tests/service/get_instances_rpc_test.dart:6: import 'dart:async'; On 2015/05/04 21:02:03, turnidge wrote: > Kill ...
5 years, 7 months ago (2015-05-04 21:29:08 UTC) #4
Cutch
5 years, 7 months ago (2015-05-04 21:29:17 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 45511 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698