Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Side by Side Diff: runtime/observatory/tests/service/get_heap_map_rpc_test.dart

Issue 1127693003: Fix analyzer warnings in service tests (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // VMOptions=--compile-all --error_on_bad_type --error_on_bad_override 4 // VMOptions=--compile-all --error_on_bad_type --error_on_bad_override
5 5
6 import 'dart:async';
7
8 import 'package:observatory/service_io.dart'; 6 import 'package:observatory/service_io.dart';
9 import 'package:unittest/unittest.dart'; 7 import 'package:unittest/unittest.dart';
10 8
11 import 'test_helper.dart'; 9 import 'test_helper.dart';
12 10
13 var tests = [ 11 var tests = [
14 (Isolate isolate) async { 12 (Isolate isolate) async {
15 var params = { 13 var params = {
16 }; 14 };
17 var result = await isolate.invokeRpcNoUpgrade('getHeapMap', params); 15 var result = await isolate.invokeRpcNoUpgrade('getHeapMap', params);
18 expect(result['type'], equals('HeapMap')); 16 expect(result['type'], equals('HeapMap'));
19 expect(result['freeClassId'], isPositive); 17 expect(result['freeClassId'], isPositive);
20 expect(result['unitSizeBytes'], isPositive); 18 expect(result['unitSizeBytes'], isPositive);
21 expect(result['pageSizeBytes'], isPositive); 19 expect(result['pageSizeBytes'], isPositive);
22 expect(result['classList'], isNotNull); 20 expect(result['classList'], isNotNull);
23 expect(result['pages'].length, isPositive); 21 expect(result['pages'].length, isPositive);
24 expect(result['pages'][0]['objectStart'], new isInstanceOf<String>()); 22 expect(result['pages'][0]['objectStart'], new isInstanceOf<String>());
25 expect(result['pages'][0]['objects'].length, isPositive); 23 expect(result['pages'][0]['objects'].length, isPositive);
26 expect(result['pages'][0]['objects'][0], isPositive); 24 expect(result['pages'][0]['objects'][0], isPositive);
27 }, 25 },
28 ]; 26 ];
29 27
30 main(args) async => runIsolateTests(args, tests); 28 main(args) async => runIsolateTests(args, tests);
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698