Issue 11276042: Explicitly configure git committer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11276042: Explicitly configure git committer. (Closed)

Created:
8 years, 1 month ago by Bob Nystrom

Modified:
8 years, 1 month ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Explicitly configure git committer. Committed: https://code.google.com/p/dart/source/detail?r=14312

Patch Set 2 : Respond to review. #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -22 lines)			Patch
	M	utils/pub/io.dart	View	1	3 chunks	+21 lines, -12 lines	0 comments	Download
	M	utils/tests/pub/test_pub.dart	View	1	2 chunks	+15 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

I won't be able to check this in until https://codereview.chromium.org/11260048/ is in, but if I'm ...

8 years, 1 month ago (2012-10-26 00:02:00 UTC) #1

nweiz

lgtm https://codereview.chromium.org/11276042/diff/1/utils/tests/pub/test_pub.dart File utils/tests/pub/test_pub.dart (right): https://codereview.chromium.org/11276042/diff/1/utils/tests/pub/test_pub.dart#newcode1060 utils/tests/pub/test_pub.dart:1060: var environment = new Map.from(Platform.environment); Should the environment ...

8 years, 1 month ago (2012-10-26 18:34:06 UTC) #2