Explicitly configure git committer.

utils/tests/pub/test_pub.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Test infrastructure for testing pub. Unlike typical unit tests, most pub
  * tests are integration tests that stage some stuff on the file system, run
  * pub, and then validate the results. This library provides an API to build
  * tests like that.
  */
@@ skipping 1032 matching lines @@
     var workingDir;
 
     Future runGitStep(_) {
       if (commands.isEmpty) return new Future.immediate(workingDir);
       var command = commands.removeAt(0);
       return _runGit(command, workingDir).chain(runGitStep);
     }
 
     return super.create(parentDir).chain((rootDir) {
       workingDir = rootDir;
-      return writeTextFile(join(parentDir, '.gitconfig'), '''
-[user]
-  name = Test Pub
-  email = pub@dartlang.org
-''');
-    }).chain(runGitStep);
+      return runGitStep(null);
+    });
   }
 
   Future<String> _runGit(List<String> args, Directory workingDir) {
-    return runGit(args, workingDir: workingDir.path).transform((result) {
+    // Explicitly specify the committer information. Git needs this to commit
+    // and we don't want to rely on the buildbots having this already set up.
+    var environment = new Map.from(Platform.environment);

[nweiz, 2012/10/26 18:34:06]

Should the environment argument be automatically merged with
Platform.environment in io.dart?

[Bob Nystrom, 2012/10/30 22:09:26]

Done.

+    environment['GIT_COMMITTER_NAME'] = 'Pub Test';
+    environment['GIT_COMMITTER_EMAIL'] = 'pub@dartlang.org';
+
+    return runGit(args, workingDir: workingDir.path,
+        environment: environment).transform((result) {
       if (!result.success) {
         throw "Error running: git ${Strings.join(args, ' ')}\n"
             "${Strings.join(result.stderr, '\n')}";
       }
 
       return result.stdout;
     });
   }
 }
 
@@ skipping 142 matching lines @@
 }
 
 /**
  * Schedules a callback to be called after Pub is run with [runPub], even if it
  * fails.
  */
 void _scheduleCleanup(_ScheduledEvent event) {
   if (_scheduledCleanup == null) _scheduledCleanup = [];
   _scheduledCleanup.add(event);
 }