Issue 11269004: Change List.sort to not have a default parameter value.

Issue 11269004: Change List.sort to not have a default parameter value. (Closed)

Created:
8 years, 2 months ago by Lasse Reichstein Nielsen

Modified:
8 years ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Change List.sort to not have a default parameter value. The list implementations in the system now default to Comparable.compare if the compare argument is null. BUG=http://code.google.com/p/dart/issues/detail?id=7148 Committed: https://code.google.com/p/dart/source/detail?r=15771

Patch Set 1 #

Patch Set 2 : ONly default if parameter no provided, not if null was passed.\ #

Patch Set 3 : Updated to tup of tree. #

Total comments: 6

Patch Set 4 : Reverted used of ?compare #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+113 lines, -135 lines)			Patch
M	runtime/lib/array.dart	View	1 2 3	2 chunks	+3 lines, -2 lines	0 comments	Download
M	runtime/lib/byte_array.dart	View	1 2 3	2 chunks	+4 lines, -2 lines	0 comments	Download
M	runtime/lib/growable_array.dart	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	samples/swarm/swarm_ui_lib/observable/observable.dart	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/js_array.dart	View	1 2 3	2 chunks	+3 lines, -2 lines	0 comments	Download
M	sdk/lib/core/list.dart	View	1 2	1 chunk	+6 lines, -2 lines	0 comments	Download
M	sdk/lib/core/sequences.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1 2 3	40 chunks	+37 lines, -69 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	1 2 3	37 chunks	+37 lines, -37 lines	0 comments	Download
M	sdk/lib/html/src/FilteredElementList.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/html/templates/html/impl/impl_Element.darttemplate	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/html/templates/html/impl/impl_Node.darttemplate	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/html/templates/immutable_list_mixin.darttemplate	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/svg/dart2js/svg_dart2js.dart	View	1 2 3	6 chunks	+6 lines, -6 lines	0 comments	Download
M	sdk/lib/svg/dartium/svg_dartium.dart	View	1 2 3	6 chunks	+6 lines, -6 lines	0 comments	Download
M	tests/corelib/const_list_literal_test.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

There is now a bug reported on this. Let's do this CL.

8 years ago (2012-12-05 14:08:03 UTC) #2

floitsch

8 years ago (2012-12-05 17:13:02 UTC) #3

LGTM.

https://codereview.chromium.org/11269004/diff/4002/runtime/lib/array.dart
File runtime/lib/array.dart (right):

https://codereview.chromium.org/11269004/diff/4002/runtime/lib/array.dart#new...
runtime/lib/array.dart:96: if (!?compare) compare = Comparable.compare;
compare == null

https://codereview.chromium.org/11269004/diff/4002/runtime/lib/byte_array.dart
File runtime/lib/byte_array.dart (right):

https://codereview.chromium.org/11269004/diff/4002/runtime/lib/byte_array.dar...
runtime/lib/byte_array.dart:227: if (!?compare) compare = Comparable.compare;
compare == null

https://codereview.chromium.org/11269004/diff/4002/runtime/lib/byte_array.dar...
runtime/lib/byte_array.dart:1772: if (!?compare) compare = Comparable.compare;
compare == null

https://codereview.chromium.org/11269004/diff/4002/runtime/lib/growable_array...
File runtime/lib/growable_array.dart (right):

https://codereview.chromium.org/11269004/diff/4002/runtime/lib/growable_array...
runtime/lib/growable_array.dart:215: if (!?compare) compare =
Comparable.compare;
compare == null

https://codereview.chromium.org/11269004/diff/4002/samples/swarm/swarm_ui_lib...
File samples/swarm/swarm_ui_lib/observable/observable.dart (right):

https://codereview.chromium.org/11269004/diff/4002/samples/swarm/swarm_ui_lib...
samples/swarm/swarm_ui_lib/observable/observable.dart:162: if (!?compare)
compare = Comparable.compare;
compare == null

https://codereview.chromium.org/11269004/diff/4002/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/lib/js_array.dart (right):

https://codereview.chromium.org/11269004/diff/4002/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/lib/js_array.dart:142: if (!?compare)
compare = Comparable.compare;
compare == null

Expand Messages | Collapse Messages