Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Unified Diff: sdk/lib/svg/dart2js/svg_dart2js.dart

Issue 11269004: Change List.sort to not have a default parameter value. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Reverted used of ?compare Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/html/templates/immutable_list_mixin.darttemplate ('k') | sdk/lib/svg/dartium/svg_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/svg/dart2js/svg_dart2js.dart
diff --git a/sdk/lib/svg/dart2js/svg_dart2js.dart b/sdk/lib/svg/dart2js/svg_dart2js.dart
index 96ff2bff2ce635cf4e76dcfe62356dcce26e6ba8..ce9297a98dc52b7af3339db82841900bd1cbe153 100644
--- a/sdk/lib/svg/dart2js/svg_dart2js.dart
+++ b/sdk/lib/svg/dart2js/svg_dart2js.dart
@@ -2780,7 +2780,7 @@ class LengthList implements JavaScriptIndexingBehavior, List<Length> native "*SV
// contains() defined by IDL.
- void sort([Comparator compare = Comparable.compare]) {
+ void sort([int compare(Length a, Length b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -3301,7 +3301,7 @@ class NumberList implements JavaScriptIndexingBehavior, List<Number> native "*SV
// contains() defined by IDL.
- void sort([Comparator compare = Comparable.compare]) {
+ void sort([int compare(Number a, Number b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -4001,7 +4001,7 @@ class PathSegList implements JavaScriptIndexingBehavior, List<PathSeg> native "*
// contains() defined by IDL.
- void sort([Comparator compare = Comparable.compare]) {
+ void sort([int compare(PathSeg a, PathSeg b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -4719,7 +4719,7 @@ class StringList implements JavaScriptIndexingBehavior, List<String> native "*SV
// contains() defined by IDL.
- void sort([Comparator compare = Comparable.compare]) {
+ void sort([int compare(String a, String b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -5704,7 +5704,7 @@ class TransformList implements List<Transform>, JavaScriptIndexingBehavior nativ
// contains() defined by IDL.
- void sort([Comparator compare = Comparable.compare]) {
+ void sort([int compare(Transform a, Transform b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -6109,7 +6109,7 @@ class _ElementInstanceList implements JavaScriptIndexingBehavior, List<ElementIn
throw new UnsupportedError("Cannot clear immutable List.");
}
- void sort([Comparator compare = Comparable.compare]) {
+ void sort([int compare(ElementInstance a, ElementInstance b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
« no previous file with comments | « sdk/lib/html/templates/immutable_list_mixin.darttemplate ('k') | sdk/lib/svg/dartium/svg_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698