Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1039)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11263040: Make String.charCodes a getter. (Closed)

Created:
8 years, 1 month ago by floitsch
Modified:
8 years, 1 month ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make String.charCodes a getter. Committed: https://code.google.com/p/dart/source/detail?r=14078

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update status files with co19 issue number. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -96 lines) Patch
M lib/compiler/implementation/lib/interceptors.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/scanner/byte_strings.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/core/string.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/utf/utf16.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/utf/utf_core.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/intl/lib/number_format.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/bin/http_impl.dart View 5 chunks +8 lines, -8 lines 0 comments Download
M runtime/bin/mime_multipart_parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/websocket_impl.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/lib/string_base.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/chat/chat_server_lib.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M samples/logo/logo.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/markdown/markdown.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-dart2dart.status View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tests/compiler/dart2js_extra/bailout_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/collection_to_string_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/is_operator_basic_types_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/string_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/crypto/base64_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/standalone/crypto/base64_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/standalone/io/file_input_stream_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/io/file_system_links_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/file_test.dart View 5 chunks +7 lines, -7 lines 0 comments Download
M tests/standalone/io/http_basic_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_parser_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/io/http_read_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/io/http_server_early_client_close_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_server_socket_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/mime_multipart_parser_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/io/process_run_output_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/process_stderr_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/process_stdout_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/regress-1925.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/socket_close_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/io/socket_stream_close_test.dart View 5 chunks +10 lines, -10 lines 0 comments Download
M tests/standalone/io/string_stream_test.dart View 8 chunks +8 lines, -8 lines 0 comments Download
M utils/peg/pegparser.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/utils.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/yaml/composer.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/yaml/model.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/test_pub.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/string_encoding/benchmark_runner.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M utils/tests/string_encoding/utf16_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/string_encoding/utf32_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/string_encoding/utf8_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
floitsch
8 years, 1 month ago (2012-10-25 14:06:27 UTC) #1
Mads Ager (google)
LGTM https://codereview.chromium.org/11263040/diff/1/tests/co19/co19-dart2dart.status File tests/co19/co19-dart2dart.status (right): https://codereview.chromium.org/11263040/diff/1/tests/co19/co19-dart2dart.status#newcode93 tests/co19/co19-dart2dart.status:93: # The following test uses String.charCodes as a ...
8 years, 1 month ago (2012-10-25 14:18:09 UTC) #2
floitsch
8 years, 1 month ago (2012-10-25 14:21:41 UTC) #3 
https://codereview.chromium.org/11263040/diff/1/tests/co19/co19-dart2dart.status
File tests/co19/co19-dart2dart.status (right):

https://codereview.chromium.org/11263040/diff/1/tests/co19/co19-dart2dart.sta...
tests/co19/co19-dart2dart.status:93: # The following test uses String.charCodes
as a functions instead of as a getter.
On 2012/10/25 14:18:09, Mads Ager wrote:
> Update with co19 bug report number before commit.

Done.

Powered by Google App Engine
This is Rietveld 408576698