runtime/bin/websocket_impl.dart - Issue 11263040: Make String.charCodes a getter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/websocket_impl.dart

Issue 11263040: Make String.charCodes a getter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Update status files with co19 issue number. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/websocket_impl.dart

diff --git a/runtime/bin/websocket_impl.dart b/runtime/bin/websocket_impl.dart

index f462713bcf2db1c43e27464682b8bab1775d31b0..0d2089d0d7c6e6e5cd71fcdbd69b22a048a02e30 100644

--- a/runtime/bin/websocket_impl.dart

+++ b/runtime/bin/websocket_impl.dart

@@ -598,7 +598,7 @@ class _WebSocketHandler implements WebSocketHandler {

response.headers.add(HttpHeaders.UPGRADE, "websocket");

String key = request.headers.value("Sec-WebSocket-Key");

SHA1 sha1 = new SHA1();

- sha1.update("$key$_webSocketGUID".charCodes());

+ sha1.update("$key$_webSocketGUID".charCodes);

String accept = _Base64._encode(sha1.digest());

response.headers.add("Sec-WebSocket-Accept", accept);

response.contentLength = 0;

@@ -747,7 +747,7 @@ class _WebSocketClientConnection

return false;

}

SHA1 sha1 = new SHA1();

- sha1.update("$_nonce$_webSocketGUID".charCodes());

+ sha1.update("$_nonce$_webSocketGUID".charCodes);

List<int> expectedAccept = sha1.digest();

List<int> receivedAccept = _Base64._decode(accept);

if (expectedAccept.length != receivedAccept.length) return false;

« no previous file with comments | « runtime/bin/mime_multipart_parser.dart ('k') | runtime/lib/string_base.dart » ('j') | no next file with comments »