Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Issue 1126233009: Instead of aborting in Builtin::LoadAndCheckLibrary let the caller handle the error condition accor… (Closed)

Created:
5 years, 7 months ago by siva
Modified:
5 years, 7 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Instead of aborting in Builtin::LoadAndCheckLibrary let the caller handle the error condition accordingly. R=rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=45804

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M runtime/bin/builtin.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/builtin_nolib.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/dartutils.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/bin/main.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
siva
5 years, 7 months ago (2015-05-14 23:24:23 UTC) #2
rmacnak
lgtm
5 years, 7 months ago (2015-05-14 23:27:21 UTC) #3
siva
5 years, 7 months ago (2015-05-14 23:28:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r45804 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698