runtime/bin/dartutils.cc - Issue 1126233009: Instead of aborting in Builtin::LoadAndCheckLibrary let the caller handle the error condition accor…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/dartutils.cc

Issue 1126233009: Instead of aborting in Builtin::LoadAndCheckLibrary let the caller handle the error condition accor… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/dartutils.cc

===================================================================

--- runtime/bin/dartutils.cc (revision 45802)

+++ runtime/bin/dartutils.cc (working copy)

@@ -381,6 +381,7 @@

// Resolve the url within the context of the library's URL.

Dart_Handle builtin_lib =

Builtin::LoadAndCheckLibrary(Builtin::kBuiltinLibrary);

+ DART_CHECK_VALID(builtin_lib);

return ResolveUri(library_url, url, builtin_lib);

}

@@ -420,6 +421,7 @@

Dart_Handle builtin_lib =

Builtin::LoadAndCheckLibrary(Builtin::kBuiltinLibrary);

+ DART_CHECK_VALID(builtin_lib);

if (DartUtils::IsDartExtensionSchemeURL(url_string)) {

// Load a native code shared library to use in a native extension

if (tag != Dart_kImportTag) {

« no previous file with comments | « runtime/bin/builtin_nolib.cc ('k') | runtime/bin/main.cc » ('j') | no next file with comments »