Issue 112613003: Fix for dart2js mirrors caching with custom elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 112613003: Fix for dart2js mirrors caching with custom elements (Closed)

Created:
7 years ago by Jennifer Messerly

Modified:
7 years ago

Reviewers:
Siggi Cherem (dart-lang), blois

CC:
reviews_dartlang.org, Alan Knight

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix for dart2js mirrors caching with custom elements Custom elements code is from https://github.com/dart-lang/CustomElements/pull/4 R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=31296

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -1 line)			Patch
M	pkg/custom_element/lib/custom-elements.debug.js	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	pkg/custom_element/lib/custom-elements.min.js	View	1 chunk	+1 line, -1 line	0 comments	Download
A	tests/html/custom/mirrors_test.dart	View	1 chunk	+66 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

dart2js mirrors cache relies on the .constructor property: https://code.google.com/p/dart/source/browse/branches/bleeding_edge/dart/sdk/lib/_internal/lib/js_mirrors.dart#856 I'm not sure if it should, ...

7 years ago (2013-12-19 02:52:23 UTC) #1

Jennifer Messerly

7 years ago (2013-12-19 19:56:01 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r31296 (presubmit successful).

Expand Messages | Collapse Messages