Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: tests/html/custom/mirrors_test.dart

Issue 112613003: Fix for dart2js mirrors caching with custom elements (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/custom_element/lib/custom-elements.min.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/html/custom/mirrors_test.dart
diff --git a/tests/html/custom/mirrors_test.dart b/tests/html/custom/mirrors_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..ea6b091d44e5abeaa2e9e23842baa9212313bf4c
--- /dev/null
+++ b/tests/html/custom/mirrors_test.dart
@@ -0,0 +1,66 @@
+// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+library tests.html.mirrors_test;
+
+import 'dart:mirrors';
+import 'dart:html';
+import 'package:unittest/unittest.dart';
+import 'package:unittest/html_config.dart';
+import '../utils.dart';
+
+/// Regression test for a tricky mirrors+custom_elements issue:
+/// dart2js mirrors cache dispatch information on the Object's constructor.
+/// This was failing for custom elements on IE 10, because the constructor was
+/// HTMLUnknownElement for all of them. So mirrors called the wrong method.
+main() {
+ useHtmlConfiguration();
+
+ var registered = false;
+ setUp(() => loadPolyfills().then((_) {
+ if (!registered) {
+ registered = true;
+ document.register(A.tag, A);
+ document.register(B.tag, B);
+ }
+ }));
+
+ test('dynamic dispatch', () {
+ var a = new A();
+ expect(a.fooBar, 1);
+ reflect(a).setField(#fooBar, 123);
+ expect(a.fooBar, 123);
+
+ // Even though A was set first, B.fooBar= should dispatch to B.
+ var b = new B();
+ expect(b.fooBar, 2);
+ expect(b._fooBarSet, 0);
+ reflect(b).setField(#fooBar, 123);
+ expect(b.fooBar, 123);
+ expect(b._fooBarSet, 1);
+ });
+}
+
+class A extends HtmlElement {
+ static final tag = 'x-a';
+ factory A() => new Element.tag(tag);
+ A.created() : super.created();
+
+ int fooBar = 1;
+}
+
+class B extends HtmlElement {
+ static final tag = 'x-b';
+ factory B() => new Element.tag(tag);
+ B.created() : super.created();
+
+ int _fooBar = 2;
+ int _fooBarSet = 0;
+
+ int get fooBar => _fooBar;
+ set fooBar(value) {
+ _fooBarSet++;
+ _fooBar = value;
+ }
+}
« no previous file with comments | « pkg/custom_element/lib/custom-elements.min.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698