Issue 1125083002: dart2js: Access to metadata and types goes through builtins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1125083002: dart2js: Access to metadata and types goes through builtins. (Closed)

Created:
5 years, 7 months ago by floitsch

Modified:
5 years, 7 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

dart2js: Access to metadata and types goes through builtins. Instead of exposing an embedded constant "METADATA" and "TYPES" provide a builtin-function that reads these values. This allows us to implement the metadata and types table differently. In particular we want to be able to generate them lazily. R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=45574

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+78 lines, -26 lines)			Patch
M	pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart	View	2 chunks	+12 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/js_lib/js_helper.dart	View	5 chunks	+30 lines, -22 lines	0 comments	Download
M	sdk/lib/_internal/compiler/js_lib/shared/embedded_names.dart	View	3 chunks	+20 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

floitsch

5 years, 7 months ago (2015-05-06 21:20:27 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 45574 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages