pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart - Issue 1125083002: dart2js: Access to metadata and types goes through builtins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart

Issue 1125083002: dart2js: Access to metadata and types goes through builtins. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart ('k') | pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart

diff --git a/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart b/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart

index 23646b7d6436cf3c52d6c31c6a86da2415abb94e..081270bbf351ae88e7fc01d80dc49a54dc98b8d1 100644

--- a/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart

+++ b/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart

@@ -66,8 +66,12 @@ class ModelEmitter {

}

js.Expression generateEmbeddedGlobalAccess(String global) {

- // TODO(floitsch): We should not use "init" for globals.

- return js.js("init.$global");

+ return js.js(generateEmbeddedGlobalAccessString(global));

+ }

+ String generateEmbeddedGlobalAccessString(String global) {

+ // TODO(floitsch): don't use 'init' as global embedder storage.

+ return 'init.$global';

}

bool isConstantInlinedOrAlreadyEmitted(ConstantValue constant) {