Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 1124173002: Implement Smi_bitLength intrinsic on mips, arm, and arm64. (Closed)

Created:
5 years, 7 months ago by regis
Modified:
5 years, 7 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Implement Smi_bitLength intrinsic on mips, arm, and arm64. Add support for clz instruction in arm64 assembler, disassembler, and simulator. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=45564

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -6 lines) Patch
M runtime/vm/assembler_arm64.h View 2 chunks +20 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm64_test.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M runtime/vm/constants_arm64.h View 2 chunks +8 lines, -0 lines 0 comments Download
M runtime/vm/disassembler_arm64.cc View 2 chunks +19 lines, -0 lines 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 1 chunk +8 lines, -1 line 0 comments Download
M runtime/vm/intrinsifier_arm64.cc View 1 chunk +9 lines, -1 line 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier_mips.cc View 1 chunk +10 lines, -1 line 0 comments Download
M runtime/vm/simulator_arm64.cc View 3 chunks +40 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
regis
5 years, 7 months ago (2015-05-06 12:52:51 UTC) #2
srdjan
lgtm
5 years, 7 months ago (2015-05-06 13:53:12 UTC) #3
regis
5 years, 7 months ago (2015-05-06 13:56:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r45564 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698