runtime/vm/intrinsifier_ia32.cc - Issue 1124173002: Implement Smi_bitLength intrinsic on mips, arm, and arm64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intrinsifier_ia32.cc

Issue 1124173002: Implement Smi_bitLength intrinsic on mips, arm, and arm64. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intrinsifier_ia32.cc

===================================================================

--- runtime/vm/intrinsifier_ia32.cc (revision 45551)

+++ runtime/vm/intrinsifier_ia32.cc (working copy)

@@ -789,7 +789,7 @@

// Argument is Smi (receiver).

void Intrinsifier::Smi_bitNegate(Assembler* assembler) {

- __ movl(EAX, Address(ESP, + 1 * kWordSize)); // Index.

+ __ movl(EAX, Address(ESP, + 1 * kWordSize)); // Receiver.

__ notl(EAX);

__ andl(EAX, Immediate(~kSmiTagMask)); // Remove inverted smi-tag.

__ ret();

@@ -798,7 +798,7 @@

void Intrinsifier::Smi_bitLength(Assembler* assembler) {

ASSERT(kSmiTagShift == 1);

- __ movl(EAX, Address(ESP, + 1 * kWordSize)); // Index.

+ __ movl(EAX, Address(ESP, + 1 * kWordSize)); // Receiver.

// XOR with sign bit to complement bits if value is negative.

__ movl(ECX, EAX);

__ sarl(ECX, Immediate(31)); // All 0 or all 1.

« no previous file with comments | « runtime/vm/intrinsifier_arm64.cc ('k') | runtime/vm/intrinsifier_mips.cc » ('j') | no next file with comments »