Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 11238047: Add a version file to the SDK (in preparation for eventually removing the revision file). (Closed)

Created:
8 years, 2 months ago by devoncarew
Modified:
8 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add a version file to the SDK (in preparation for eventually removing the revision file). Committed: https://code.google.com/p/dart/source/detail?r=13983

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -10 lines) Patch
M README.dart-sdk View 1 chunk +1 line, -1 line 0 comments Download
M tools/create_sdk.py View 1 4 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
devoncarew
@Rico, this adds the version file back into the SDK w/o removing the revision file. ...
8 years, 2 months ago (2012-10-22 22:25:12 UTC) #1
dgrove
lgtm @rnystrom - you'll want to take a look as well. https://chromiumcodereview.appspot.com/11238047/diff/1/tools/create_sdk.py File tools/create_sdk.py (right): ...
8 years, 2 months ago (2012-10-22 22:36:13 UTC) #2
Bob Nystrom
+nathan Filed a tracking bug for the pub side of this: http://code.google.com/p/dart/issues/detail?id=6173
8 years, 2 months ago (2012-10-22 22:49:35 UTC) #3
nweiz
On 2012/10/22 22:49:35, Bob Nystrom wrote: > +nathan > > Filed a tracking bug for ...
8 years, 2 months ago (2012-10-23 00:29:36 UTC) #4
devoncarew
8 years, 2 months ago (2012-10-23 14:17:32 UTC) #5
>Is there any chance we can make the version file match the semantic versioning
> format pub uses (http://semver.org)? It seems confusing to have the version
that
> "dart --version" prints out be different from the version that users specify
in
> their pubspecs.

I agree re: consistency but it's not a change for this CL. The vm. editor,
dartium, and (now) the SDK all pull their version from the tool/version.dart
script (and the tools/VERSION file). I'd open a separate email thread w/ the
proposed change to the format.

https://chromiumcodereview.appspot.com/11238047/diff/1/tools/create_sdk.py
File tools/create_sdk.py (right):

https://chromiumcodereview.appspot.com/11238047/diff/1/tools/create_sdk.py#ne...
tools/create_sdk.py:312: dest_dir = join (ANALYZER_DEST,
os.path.dirname(jarToCopy))
On 2012/10/22 22:36:13, dgrove wrote:
> why this whitespace change?

It's not clear from this UI - these 5 lines were indented by 4 spaces, not 2.
pylint complained; I think the indentation is correct now but I can revert this
ws change if you like.

https://chromiumcodereview.appspot.com/11238047/diff/1/tools/create_sdk.py#ne...
tools/create_sdk.py:341: with open(os.path.join(SDK_tmp, 'version'), 'w') as f:
On 2012/10/22 22:36:13, dgrove wrote:
> this differs from the way open(..., 'w') was done at line 78

I changed this to be more consistent w/ that other open/write/close section.

Powered by Google App Engine
This is Rietveld 408576698